Skip to content

Missing escaping for XML error message #65047 #11527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maheshpatel27 wants to merge 2 commits into
base: trunk
Choose a base branch
from
+1 −1
Open

Missing escaping for XML error message #65047 #11527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c69af02
output in XML without escaping
maheshpatel27 Apr 9, 2026
10f34d7
Update code
maheshpatel27 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-trackback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function trackback_response( $error = 0, $error_message = '' ) {
echo '<?xml version="1.0" encoding="utf-8"?' . ">\n";
echo "<response>\n";
echo "<error>1</error>\n";
echo "<message>$error_message</message>\n";
echo "<message>" . esc_html ( $error_message ) . "</message>\n";
Copy link
Copy Markdown

@pbiron pbiron Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @sabernhardt in his comment on the ticket that esc_xml() would better here than esc_html()

Copy link
Copy Markdown

@sabernhardt sabernhardt Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switching the function, and removing a space after the function name:

Suggested change
echo "<message>" . esc_html ( $error_message ) . "</message>\n";
echo "<message>" . esc_xml( $error_message ) . "</message>\n";

echo '</response>';
die();
} else {
Expand Down
Loading