Prefix SQLite-specific constructor options - #481
Open
JanJakes wants to merge 1 commit into
Open
Conversation
Rename the WP_MySQL_On_SQLite options to sqlite_pdo, sqlite_journal_mode, and sqlite_synchronous without compatibility aliases. Keep the legacy WP_SQLite_Connection option names unchanged.
JanJakes
force-pushed
the
driver-options
branch
from
August 7, 2026 16:10
909bdfe to
fdf34cb
Compare
JanJakes
commented
Aug 7, 2026
| * @type int $mysql_version Optional. MySQL version to emulate. Default 80038. | ||
| * @type PDO|null $sqlite_pdo Optional. Existing PDO SQLite connection. | ||
| * @type string|null $sqlite_journal_mode Optional. SQLite journal mode. Default 'WAL'. | ||
| * @type string|int|null $sqlite_synchronous Optional. SQLite synchronous setting. |
Member
Author
There was a problem hiding this comment.
The only non-vendored external consumer that passes these options is Automattic/markdown-database-integration, which uses pdo and journal_mode and can be updated alongside this change. The other GitHub matches are vendored copies of this repository; Veloria finds no WordPress.org plugin consumers.
JanJakes
marked this pull request as ready for review
August 7, 2026 16:23
adamziel
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the SQLite-specific
WP_MySQL_On_SQLiteconstructor options so their ownership is explicit:pdo→sqlite_pdojournal_mode→sqlite_journal_modesynchronous→sqlite_synchronousThe documentation, internal callers, and tests now use the prefixed names.
Rationale
WP_MySQL_On_SQLiteaccepts standard numeric PDO constructor options alongside its own string-keyed options. The generic names did not clearly distinguish SQLite connection configuration from PDO attributes or other driver configuration. Thesqlite_prefix makes that boundary explicit.