Skip to content

Vacate public processor paths for exact file moves - #304

Merged
adamziel merged 1 commit into
trunkfrom
adamziel/prepare-processor-file-moves
Aug 7, 2026
Merged

Vacate public processor paths for exact file moves#304
adamziel merged 1 commit into
trunkfrom
adamziel/prepare-processor-file-moves

Conversation

@adamziel

@adamziel adamziel commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Moves the four public alias loaders into temporary loaders/ directories so #303 can present the implementation relocations as exact Git renames.

The temporary loaders accept either adjacent stack state: the implementations under PHP/ in this PR, or the public paths after #303. The implementation files receive only a PHPCS directive that moves with their unchanged bytes. #305 removes the loaders and directives while restoring the public class declarations.

Stack

  1. Vacate public processor paths for exact file moves #304 — vacate the destination paths
  2. Move processor implementations to their public paths #303 — move four byte-identical implementation files
  3. Restore public processor class declarations #305 — restore the public class declarations and remove temporary loaders

After each base PR merges, retarget the next PR to trunk.

Testing

The Data Liberation, XML, and Markdown suites pass. PHPCS, syntax checks, direct-loader checks, and root-autoload checks pass.

@adamziel
adamziel marked this pull request as ready for review August 7, 2026 15:44
@adamziel
adamziel merged commit 7c9ea44 into trunk Aug 7, 2026
29 checks passed
@adamziel
adamziel deleted the adamziel/prepare-processor-file-moves branch August 7, 2026 16:02
adamziel added a commit that referenced this pull request Aug 7, 2026
Moves the retained URL-in-text, HTML, and XML implementation files out
of the `PHP/` sidecar directories and into their public processor paths.

Files changed contains exactly four 100% renames with zero additions and
zero deletions. No implementation byte changes in this PR.

## Stack

1. #304 — vacate the destination paths
2. #303 — move four byte-identical implementation files
3. #305 — restore the public class declarations and remove temporary
loaders

## Testing

The Data Liberation, XML, and Markdown suites pass. PHPCS, syntax
checks, direct-loader checks, and root-autoload checks pass.
adamziel added a commit that referenced this pull request Aug 7, 2026
Renames the four relocated `PHP*` implementation classes to their public
names and removes the temporary loaders introduced by #304.

With #303 merged, Files changed contains only the class declaration
cleanup and temporary-loader removal. The resulting tree contains
neither the retired `PHP*` class names nor the `PHP/` and `loaders/`
directories.

## Stack

1. #304 — vacate the destination paths
2. #303 — move four byte-identical implementation files
3. #305 — restore the public class declarations and remove temporary
loaders

## Testing

The Data Liberation, XML, and Markdown suites pass. PHPCS and syntax
checks pass. A root-autoload check confirms the public classes load, the
retired `PHP*` classes do not, and `WP_HTML_Processor` remains a
`WP_HTML_Tag_Processor` subclass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant