Fix docs parsing of CommonMark children#267
Open
ashfame wants to merge 1 commit into
Open
Conversation
ashfame
requested review from
a team,
JanJakes and
adamziel
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the docs deploy failure from https://github.com/WordPress/php-toolkit/actions/runs/25510294479/job/74871014893#step:5:21.
The vendored CommonMark
Node::children()implementation can return a plain array.bin/build-reference.phpassumed it always returnedTraversableand passed it directly toiterator_to_array(), which fails under the docs deploy PHP 8.1 job.This adds a small
node_children()helper that accepts either arrays orTraversableresults, then uses it in bothbin/build-reference.phpandbin/run-snippets.php.