Open
Conversation
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
A few notes:
- It would be good to generate the log independently of whether the reports are submitted to wp.org or not. That will allow contributors to retain log files. This will require moving the log generation in the plugin as it's currently in the submission function.
- Blocker: Log files are best stored in the bash scripts directory rather than in the mu-plugins directory.
- With above, the
.gitignorefile ought to be updated to exclude the log files.
Contributor
peterwilsoncc
left a comment
There was a problem hiding this comment.
This is now recording the log file for me, thanks. For testing without submitting, I'm setting the reporter url to https://invalid.invalid which creates the log but doesn't submit, of course.
If moving the log file is too fiddly then I think it's fine to keep it in the mu-directory as this isn't intended to be run on a production machine.
- Place file in the `ABSPATH` directory. - Log the submission response and the test results separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help hosts understand what data was submitted, the values will now be saved into a log file.