Bump version to 1.0.0-rc.1 - #296
Merged
Merged
Conversation
Release candidate for 1.0, on top of the twenty changes that landed since v1.0.0-beta.1. `npm version --no-git-tag-version`, so package.json and package-lock.json move together and nothing else in the tree carries the string — electron-builder derives the artefact names from package.json. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
juanmaguitar
added a commit
that referenced
this pull request
Aug 13, 2026
## Why
`v1.0.0-rc.1` shipped on 12 August. Twenty changes have since landed on
`trunk`, including safer applied-patch handling, clearer stale-ticket
guidance, fixes for missing linked pull requests and stalled Trac loads,
and exclusion of local coding-agent files from generated patches.
This second release candidate carries those fixes, so the package
version must move to `1.0.0-rc.2` before its tag and artifacts are
created.
## What changes
Only `package.json` and `package-lock.json`: all three package-version
fields move together from `1.0.0-rc.1` to `1.0.0-rc.2`. No dependency
versions or application behavior change.
`electron-builder` derives artifact names from `package.json`,
producing:
- `wordpress-contributor-toolkit-1.0.0-rc.2-mac-arm64.dmg`
- `wordpress-contributor-toolkit-1.0.0-rc.2-win-x64.exe`
- `wordpress-contributor-toolkit-1.0.0-rc.2-linux-x86_64.AppImage`
## How to test this
Platforms: any; this is package metadata and is platform-independent.
**Starting state:** this branch checked out with dependencies installed.
1. Run `node -p "require('./package.json').version"`.
- Expected: `1.0.0-rc.2`.
2. Run `node -e "const p=require('./package-lock.json');
console.log(p.version, p.packages[''].version)"`.
- Expected: `1.0.0-rc.2 1.0.0-rc.2`.
3. Run `npm run lint` and `npm test`.
- Expected: lint succeeds and all 1,017 tests pass.
**What must not have happened:** dependency versions and resolved
packages must remain unchanged; no source, documentation, workflow, or
build configuration file should be in the diff.
## Risks and limitations
No user-visible behavior changed, so there is no desktop flow or
screenshot to test by hand. The signed artifacts will only exist after
this PR lands and the release build runs.
## Related
Follow-up to #296.
---
<details>
<summary>Design decisions and alternatives considered</summary>
The version remains SemVer-shaped as `1.0.0-rc.2`, matching `1.0.0-rc.1`
and keeping artifact names in one series. The release tag will add the
conventional `v` prefix; package metadata does not.
</details>
<details>
<summary>Review outcome (required — see AGENTS.md)</summary>
`0 [fix here] · 0 [follow-up]`. No findings across architecture,
security, performance, cross-platform, or tests. `npm run lint`, `npm
test` (1,017/1,017), and `git diff --check` pass.
</details>
<details>
<summary>Implementation notes</summary>
npm's documented versioning behavior keeps `package.json`, the lockfile
root version, and `packages[""]` synchronized. The diff was checked to
confirm those are the only changed values.
</details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v1.0.0-beta.1shipped on 10 August. Twenty changes have landed ontrunksince — the setup chain, the decoupled build watch, the failed-apply explanation, the ticket's own facts, the toasts. That is the release candidate for 1.0, so the version moves to1.0.0-rc.1before the tag is cut.What changes
package.jsonandpackage-lock.json, and nothing else. Written bynpm version 1.0.0-rc.1 --no-git-tag-versionrather than by hand, so the lockfile's two copies of the string move with it.git grep 1.0.0-betaoutside the lockfile returns nothing, so no doc, workflow or script carries the version.electron-builderderives the artefact names frompackage.json, so the assets become:wordpress-contributor-toolkit-1.0.0-rc.1-mac-arm64.dmgwordpress-contributor-toolkit-1.0.0-rc.1-win-x64.exewordpress-contributor-toolkit-1.0.0-rc.1-linux-x86_64.AppImageThe
rc.1shape (notrc1) keeps the same form asbeta.1, so the filenames stay in one series.Scope
The open Gutenberg stack (#255 → #261 → #264 → #269 → #283) is deliberately not in this release candidate. An RC stabilises what is there; a feature of that size belongs in the release after it.
Review
No behaviour changes, so the review standard has nothing to grade beyond the diff itself: two version strings, produced by npm, verified against
git grep. Lint and unit tests run on this branch.🤖 Generated with Claude Code