Update README: document scan options and add network security note#987
Merged
Merged
Conversation
Replace stale "Configurable starting inverter device ID" bullet with description of the auto-scan and manual setup options added in the scan-for-inverters feature. Add Network Security section noting Modbus/TCP has no authentication and the inverter port should be firewalled from untrusted networks.
Owner
|
If the user has to enable modbus, any security notice belongs as part of the configuration steps otheriwse they won't see it. No PR is needed for that. Other stuff will get updated when a final release is ready, I always do docs last since things can change in between. There's still a few items I'm not 100% satisfied with yet. |
WillCodeForCats
requested changes
May 25, 2026
Co-authored-by: Seth <48533968+WillCodeForCats@users.noreply.github.com>
Contributor
Author
|
Moved Network Security to Wiki |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace stale "Configurable starting inverter device ID" bullet with description of the auto-scan and manual setup options added in the scan-for-inverters feature.
Add Network Security section noting Modbus/TCP has no authentication and the inverter port should be firewalled from untrusted networks.