Add missing f-prefixes to write error messages - #1038
Open
it-rec wants to merge 1 commit into
Open
Conversation
Four HomeAssistantError messages in write_registers() interpolated
nothing and showed the literal text {self._wr_unit} in the UI when a
number/select/switch write failed.
it-rec
force-pushed
the
fix/write-error-messages
branch
from
August 17, 2026 05:04
676e2e0 to
9b14338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Four error messages in the write path are missing their
fprefix, so the placeholder islogged literally:
instead of the actual device ID. The messages are the ones a user sees when a write
fails, so they are exactly the ones that need to name the device.
No logic change, only the four strings.
Testing
Not triggered on my system - my writes are intentionally disabled, so I have not produced
one of these errors on real hardware. The change is a literal string fix that is visible
by reading it: without the prefix Python emits the braces verbatim.
I would rather say that plainly than claim a test I did not run.
Checklist