Skip to content

perf: create the event listeners map on first use #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zirkelc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: create the event listeners map on first use #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions cjs/interface/event-target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ function invokeListeners({currentTarget, target}) {
*/
class DOMEventTarget {

constructor() {
wm.set(this, new Map);
}

/**
* @protected
*/
Expand All @@ -53,15 +49,18 @@ class DOMEventTarget {
}

addEventListener(type, listener, options) {
const map = wm.get(this);
// the listeners map is created on demand: most nodes never get a listener
let map = wm.get(this);
if (!map)
wm.set(this, map = new Map);
if (!map.has(type))
map.set(type, new Map);
map.get(type).set(listener, options);
}

removeEventListener(type, listener) {
const map = wm.get(this);
if (map.has(type)) {
if (map && map.has(type)) {
const listeners = map.get(type);
if (listeners.delete(listener) && !listeners.size)
map.delete(type);
Expand Down
11 changes: 5 additions & 6 deletions esm/interface/event-target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ function invokeListeners({currentTarget, target}) {
*/
class DOMEventTarget {

constructor() {
wm.set(this, new Map);
}

/**
* @protected
*/
Expand All @@ -52,15 +48,18 @@ class DOMEventTarget {
}

addEventListener(type, listener, options) {
const map = wm.get(this);
// the listeners map is created on demand: most nodes never get a listener
let map = wm.get(this);
if (!map)
wm.set(this, map = new Map);
if (!map.has(type))
map.set(type, new Map);
map.get(type).set(listener, options);
}

removeEventListener(type, listener) {
const map = wm.get(this);
if (map.has(type)) {
if (map && map.has(type)) {
const listeners = map.get(type);
if (listeners.delete(listener) && !listeners.size)
map.delete(type);
Expand Down