feat: implement pvm optimizations, robust uninstall logic and php-version auto-detection#30
Conversation
…sion auto-detection - Added confirmation prompts to 'uninstall' with a --yes bypass and automatic TTY detection. - Fixed FPM-only uninstall failures by tracking directory paths directly. - Added automatic switching to version specified in '.php-version' file in 'pvm use'. - Optimized SemVer sorting complexity by pre-parsing version strings. - Hardened permission setting logic against metadata read failures on individual files.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds .php-version resolution to ChangesCLI Enhancements & Efficiency Improvements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@GEMINI.md`:
- Line 89: Replace the workspace formatting check command string "`cargo fmt --
--check`" with the workspace-aware "`cargo fmt --all -- --check`" in the
documentation; locate the line containing the old command and update it to
ensure the CI gate and README reflect the project’s pre-commit workflow for
multi-crate formatting checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: dd944a5e-2620-48b1-8907-2fa8787f3d26
📒 Files selected for processing (8)
GEMINI.mdREADME.mdsrc/commands/uninstall.rssrc/commands/use_cmd.rssrc/interactive.rssrc/network.rssrc/utils.rstests/cli.rs
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Ben <Fahl-Design@users.noreply.github.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
## [1.3.0](v1.2.1...v1.3.0) (2026-05-22) ### Features * implement pvm optimizations, robust uninstall logic and php-version auto-detection ([#30](#30)) ([ccaa069](ccaa069))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This PR introduces verified optimizations and fixes to the PHP Version Manager (PVM).
Summary of Changes:
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by CodeRabbit
New Features
--yes/-yflag touninstallfor non-interactive confirmation.usenow reads a local.php-versionfile to select (and optionally install) a version when none is specified.Documentation
pvm self-updateusage hint to README.Improvements
Tests
uninstallanduse.