Avoid function state in IndexedDB page wait#580
Open
issackjohn wants to merge 1 commit into
Open
Conversation
The DeletingAllItems step stored its resolver as a property on the iterationFinishedListener function object and registered a listener that was never removed. Replace it with a waitForPreviousPageLoaded() helper that registers a one-shot listener for each page transition, so the resolver is local to the navigation it belongs to and the listener cleans itself up. Follow-up to the review on WebKit#531.
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review on #531.
DeletingAllItemsstored its resolver as a property on theiterationFinishedListenerfunction object and registered aprevious-page-loadedlistener that was never removed.This replaces that with a
waitForPreviousPageLoaded()helper whichregisters a one-shot listener per page transition, so the resolver is
local to the navigation it belongs to and the listener cleans itself up.