Conversation
Added link to V8 design portfolio for stack switching
Also tightened up language obout requiring traps when promise/suspending not correctly lined up.
Some of the changes that follow from reviewer's remarks. Co-authored-by: Shu-yu Guo <syg@chromium.org>
Make it clear that a 'long jump' in the meta-interpreter is being affected.
Updated test suite for jspi to reflect new API
Implementation notes
Merge remote-tracking branch 'spec/wasm-3.0'
Fix JSPI tests
Some minor tweaks in response to reviewer's remarks.
Co-authored-by: Shu-yu Guo <syg@chromium.org>
Co-authored-by: Shu-yu Guo <syg@chromium.org>
Co-authored-by: Shu-yu Guo <syg@chromium.org>
use 'marker' suffix to better distinguish Suspending objects from functions
Small changes, responding to remarks by reviewer.
Small tweak: Add an explanation for the role of the map Big tweak: Arrange to throw a JS RuntimeError rather than trap when JSPI usage not properly balanced.
Tidy up punctuation.
Clean up throwing exceptions from JS (a little bit)
Draft of spec for jspi
Use the new standard exception type SuspendError if a problem arises with trying to suspend.
Add SuspendError
fgmccabe
commented
Jun 23, 2026
Co-authored-by: Francis McCabe <fmccabe@gmail.com>
eqrion
requested changes
Jul 14, 2026
eqrion
left a comment
eqrion
left a comment
Collaborator
There was a problem hiding this comment.
This is a tricky one, and I'm still learning the spec interactions for WHATWG/TC39 so forgive me if I messed some of these comments up. I'd like to take another look at this.
Comment on lines
-6
to
13
| .. |WasmDraft| replace:: |pagelink| | ||
| .. _WasmDraft: |pagelink| | ||
| .. |WasmDraft| replace:: https://webassembly.github.io/js-promise-integration/core/ | ||
| .. _WasmDraft: https://webassembly.github.io/js-promise-integration/core/ | ||
|
|
||
| .. |WasmIssues| replace:: |issuelink| | ||
| .. _WasmIssues: |issuelink| | ||
| .. |WasmIssues| replace:: https://github.com/webassembly/js-promise-integration/issues/ | ||
| .. _WasmIssues: https://github.com/webassembly/js-promise-integration/issues/ | ||
|
|
||
| .. |IEEE754| replace:: IEEE 754 | ||
| .. |IEEE754| replace:: IEEE 754-2019 | ||
| .. _IEEE754: https://ieeexplore.ieee.org/document/8766229 |
Collaborator
There was a problem hiding this comment.
I think we want to revert these changes.
|
|
||
| .. only:: html | ||
|
|
||
| | Release |release| |
|  | ||
|  | ||
|  | ||
| [](https://travis-ci.org/WebAssembly/js-promise-integration) |
Comment on lines
1286
to
1333
Collaborator
There was a problem hiding this comment.
This looks like an accidental removal?
Comment on lines
+113
to
+114
| text: evaluation_suspend; url: appendix/embedding.html#embed-evaluation-suspend | ||
| text: evaluation_resume; url: appendix/embedding.html#embed-evaluation-resume |
Collaborator
There was a problem hiding this comment.
These are broken links. Did you intend to use them?
| 1. Set the [=surrounding agent=]'s [=associated store=] to |store|. | ||
| 1. If |result| is [=error=], throw a WebAssembly {{RuntimeError}} exception, unless otherwise indicated by <a href="#errors">the WebAssembly error mapping</a>. | ||
| 1. Otherwise, if |result| is of the form [=throw=] exnaddr, | ||
| 1. [=Reject=] |promise| with |result|. |
Collaborator
There was a problem hiding this comment.
|result| here is a throw exnaddr abstract value, and we're rejecting a promise with it. I think we need to convert the exnaddr into a JS value first.
Comment on lines
+1503
to
+1504
| 1. Otherwise, return the result of performing [=coerce a JavaScript return=] on |resultTypes| and |awaitResult|. | ||
| 1. Otherwise, return the result of performing [=coerce a JavaScript return=] on |resultTypes| and |ret|. |
Collaborator
There was a problem hiding this comment.
Both of these pass args in the reverse order the op expects.
| 1. If [$IsCallable$](|wasmFunc|) is false, throw a {{TypeError}}. | ||
| 1. If |wasmFunc| does not have a \[[FunctionAddress]] internal slot, throw a {{TypeError}}. | ||
| 1. Let |builder| be a new [=AbstractClosure=] with no parameters that captures |wasmFunc| and performs [=run a Promising function=] when called. | ||
| 1. Returns the result of [=CreateBuiltinFunction=](|builder|,1,"", « »). |
Collaborator
There was a problem hiding this comment.
Suggested change
| 1. Returns the result of [=CreateBuiltinFunction=](|builder|,1,"", « »). | |
| 1. Return the result of [=CreateBuiltinFunction=](|builder|,1,"", « »). |
Comment on lines
+1462
to
+1465
| 1. Let |suspendingProto| be \[[%WebAssembly.Suspending.prototype%]]. | ||
| 1. Let |susp| be the result of [$OrdinaryObjectCreate$](|suspendingProto|,«\[[WrappedFunction]]»). | ||
| 1. Set |susp|.\[[WrappedFunction]] to |jsFun|. | ||
| 1. Return |susp|. |
Collaborator
There was a problem hiding this comment.
WebIDL will automatically create an object for us that is wired up with the correct prototype (and other slots such as the internal platform object brand). The other WebIDL constructors in this spec just initialize the slots on the this object.
| 1. Let [|parameters|] → [|results|] be |functype|. | ||
| 1. If any type in |parameters| or |results| [=matches/valtype|matches=] [=v128=] or [=exnref=], throw a {{TypeError}}. | ||
|
|
||
| 1. If |parameters| or |results| contain [=v128=] or [=exnref=], throw a {{TypeError}}. | ||
| Note: the above error is thrown each time the \[[Call]] method is invoked. |
Collaborator
There was a problem hiding this comment.
Did you mean to delete this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR that represents merging of JSPI into main spec.