Constraints: Propagate constants when proving - #9047
Merged
Conversation
tlively
approved these changes
Aug 27, 2026
aheejin
approved these changes
Aug 27, 2026
| } | ||
| } | ||
|
|
||
| Result BasicBlockConstraintMap::proves(LocalConstraint condition) const { |
Member
There was a problem hiding this comment.
Do we plan to do more here? Like, if the otherConstraints is not equal to a literal but less than / greater than a literal, that also can help prove or disprove a constraint.
Member
Author
There was a problem hiding this comment.
Good point, yeah, we can do better here, adding constraints for such cases. I added a TODO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than seeing e.g.
x <= ..and trying to solve it using what we know aboutx, if the rhs is another localy, we can use what we know abouty. E.g.x <= y, wheny == 10, isx <= 10.