[wasm-ctor-eval] Do not error on non-constant code in the start function#8778
Open
kripken wants to merge 5 commits into
Open
[wasm-ctor-eval] Do not error on non-constant code in the start function#8778kripken wants to merge 5 commits into
kripken wants to merge 5 commits into
Conversation
tlively
approved these changes
May 26, 2026
Comment on lines
+19
to
+20
| ;; While this is non-constant and evalling it fails, vacuum does remove it, | ||
| ;; so it vanishes. |
Member
There was a problem hiding this comment.
Maybe also add a test that uses an imported global or function that will not be vacuumed away, just to make sure the vacuum isn't hiding any bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we did not catch the Nonconstant exception.