OptimizeCasts: Migrate from invalidates to orderedBefore#8774
Merged
Conversation
Replace the coarse 'invalidates' check in 'OptimizeCasts' with 'orderedBefore'. This is a cleanup to use the more precise directional effects check. Also add a new lit test to verify that casts (which have trap effects) are correctly allowed to move past global state reads but blocked by global state writes. TAG=agy
Member
Author
|
Looks like there are some unrelated failures on Windows: But I can't repro locally on Linux with the latest V8 from JSVU :/ |
aheejin
approved these changes
May 26, 2026
| ;; CHECK: (func $disallowed (type $1) (param $x (ref $struct)) | ||
| ;; CHECK-NEXT: (call $foo | ||
| ;; CHECK-NEXT: (block $label1 (result i32) | ||
| ;; CHECK-NEXT: (block $block (result i32) |
Member
Author
There was a problem hiding this comment.
This is a fix to unrelated tests that were breaking CI. I landed this separately in #8777.
Member
I can't repro them in my Cloudtop either... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the coarse 'invalidates' check in 'OptimizeCasts' with 'orderedBefore'. This is a cleanup to use the more precise directional effects check.
Also add a new lit test to verify that casts (which have trap effects) are correctly allowed to move past global state reads but blocked by global state writes.
TAG=agy