Skip to content

Increase Alpine stack size to 8MB #8595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 4 commits into from
Apr 13, 2026
+1,903 −3
Merged

Increase Alpine stack size to 8MB #8595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c6b61a
start
kripken Apr 13, 2026
6dd42b6
test
kripken Apr 13, 2026
0386aa3
undo the fix to confirm crash on ci
kripken Apr 13, 2026
374abcf
Revert "undo the fix to confirm crash on ci"
kripken Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ jobs:

# Run tests on Alpine Linux, which we use to make our release builds.
# Note: Alpine uses musl libc.
# Keep in sync with build_release.yml. The only difference is that here we
# Keep in sync with create_release.yml. The only difference is that here we
# do not have the "archive" and "upload tarball" jobs.
build-alpine:
name: alpine
Expand Down Expand Up @@ -259,8 +259,11 @@ jobs:
run: ./alpine.sh pip3 install --break-system-packages -r requirements-dev.txt

- name: cmake
# Build with an 8MB stack size, as otherwise Alpine/musl's default stack
# size for pthreads is tiny,
# https://github.com/WebAssembly/binaryen/issues/8594
run: |
./alpine.sh cmake . -G Ninja -DCMAKE_CXX_FLAGS="-static" -DCMAKE_C_FLAGS="-static" -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC_LIB=ON -DBUILD_MIMALLOC=ON -DCMAKE_INSTALL_PREFIX=install
./alpine.sh cmake . -G Ninja -DCMAKE_CXX_FLAGS="-static" -DCMAKE_C_FLAGS="-static" -DCMAKE_EXE_LINKER_FLAGS="-Wl,-z,stack-size=8388608" -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC_LIB=ON -DBUILD_MIMALLOC=ON -DCMAKE_INSTALL_PREFIX=install

- name: build
run: |
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/create_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ jobs:
${{ steps.archive-arm64.outputs.SHASUM }}
# Build with gcc 6.3 and run tests on Alpine Linux (inside chroot).
# Keep in sync with ci.yml.
# Note: Alpine uses musl libc.
build-alpine:
name: alpine
Expand Down Expand Up @@ -145,8 +146,11 @@ jobs:
run: ./alpine.sh pip3 install --break-system-packages -r requirements-dev.txt

- name: cmake
# Build with an 8MB stack size, as otherwise Alpine/musl's default stack
# size for pthreads is tiny,
# https://github.com/WebAssembly/binaryen/issues/8594
run: |
./alpine.sh cmake . -G Ninja -DCMAKE_CXX_FLAGS="-static" -DCMAKE_C_FLAGS="-static" -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC_LIB=ON -DBUILD_MIMALLOC=ON -DCMAKE_INSTALL_PREFIX=install
./alpine.sh cmake . -G Ninja -DCMAKE_CXX_FLAGS="-static" -DCMAKE_C_FLAGS="-static" -DCMAKE_EXE_LINKER_FLAGS="-Wl,-z,stack-size=8388608" -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC_LIB=ON -DBUILD_MIMALLOC=ON -DCMAKE_INSTALL_PREFIX=install
- name: build
run: |
Expand Down
Loading
Loading