Skip to content

[NFC] Fuzzer: Add a run_js() method #8588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 2 commits into from
Apr 9, 2026
+16 −9
Merged

[NFC] Fuzzer: Add a run_js() method #8588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1b20e0
nfc
kripken Apr 9, 2026
213dbb4
typo
kripken Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions scripts/fuzz_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ def note_ignored_vm_run(reason, extra_text='', amount=1):


# Run a VM command, and filter out known issues.
def run_vm(cmd):
def run_vm(cmd, checked=True):
def filter_known_issues(output):
known_issues = [
# can be caused by flatten, ssa, etc. passes
Expand Down Expand Up @@ -649,7 +649,11 @@ def filter_known_issues(output):

try:
# some known issues do not cause the entire process to fail
return filter_known_issues(run(cmd))
if checked:
ret = run(cmd)
else:
ret = run_unchecked(cmd)
return filter_known_issues(ret)
except subprocess.CalledProcessError:
# other known issues do make it fail, so re-run without checking for
# success and see if we should ignore it
Expand Down Expand Up @@ -696,6 +700,7 @@ def get_v8_extra_flags():


V8_LIFTOFF_ARGS = ['--liftoff']
V8_NO_LIFTOFF_ARGS = ['--no-liftoff']


# Default to running with liftoff enabled, because we need to pick either
Expand Down Expand Up @@ -831,8 +836,13 @@ def can_compare_to_other(self, other):
class D8:
name = 'd8'

def run(self, wasm, extra_d8_flags=[]):
return run_vm([shared.V8, get_fuzz_shell_js()] + shared.V8_OPTS + get_v8_extra_flags() + extra_d8_flags + ['--', wasm])
extra_d8_flags = []

def run_js(self, js, wasm, checked=True):
return run_vm([shared.V8, js] + shared.V8_OPTS + get_v8_extra_flags() + self.extra_d8_flags + ['--', wasm], checked=checked)

def run(self, wasm):
return self.run_js(js=get_fuzz_shell_js(), wasm=wasm)

def can_run(self, wasm):
return all_disallowed(DISALLOWED_FEATURES_IN_V8)
Expand All @@ -856,16 +866,13 @@ def can_compare_to_other(self, other):
class D8Liftoff(D8):
name = 'd8_liftoff'

def run(self, wasm):
return super().run(wasm, extra_d8_flags=V8_LIFTOFF_ARGS)
extra_d8_flags = V8_LIFTOFF_ARGS


class D8Turboshaft(D8):
name = 'd8_turboshaft'

def run(self, wasm):
flags = ['--no-liftoff']
return super().run(wasm, extra_d8_flags=flags)
extra_d8_flags = V8_NO_LIFTOFF_ARGS


class Wasm2C:
Expand Down
Loading