Skip to content

feat: Add Base64 Audio Config to Audio Connector - #360

Open
superchilled wants to merge 9 commits into
mainfrom
feat-add-base64-audio-config-audio-connector
Open

feat: Add Base64 Audio Config to Audio Connector#360
superchilled wants to merge 9 commits into
mainfrom
feat-add-base64-audio-config-audio-connector

Conversation

@superchilled

Copy link
Copy Markdown
Contributor

This PR updates the Audio Connector implementation in the Video package to add configuration options for Audio Transport. Specifically it:

  • Defines a new AudioTransportConfiguration data model for setting the Audio Transport configuration options
  • Updates the existing AudioConnectorWebSocket data model to include the audio_transport parameter
  • Defines enums for AudioTransportEncoding and AudioTransportTransport
  • Adds a new unit test for setting the Audio Transport configuration options
  • Updates the import lists in __init.py

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Video package’s Audio Connector request models to support configuring Audio Transport (e.g., JSON + Base64) and adds test coverage for the new configuration payload.

Changes:

  • Added AudioTransportConfiguration model and new enums (AudioTransportEncoding, AudioTransportTransport) to represent audio transport settings.
  • Extended AudioConnectorWebSocket to accept an audio_transport configuration and updated exports in models/__init__.py.
  • Updated unit tests to cover serialization of Audio Transport configuration.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
video/tests/test_audio_connector.py Adds/updates tests for serializing Audio Connector options, including the new audio_transport config.
video/src/vonage_video/models/enums.py Introduces enums for audio transport encoding and transport type.
video/src/vonage_video/models/audio_connector.py Adds AudioTransportConfiguration and wires it into AudioConnectorWebSocket.
video/src/vonage_video/models/__init__.py Exposes the new model and enums at the package level.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread video/tests/test_audio_connector.py
Comment thread video/src/vonage_video/models/audio_connector.py
@superchilled
superchilled removed the request for review from dragonmantank August 24, 2026 16:01
@superchilled
superchilled marked this pull request as draft August 24, 2026 16:01
@superchilled
superchilled marked this pull request as ready for review August 25, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants