feat: Add Base64 Audio Config to Audio Connector - #360
Open
superchilled wants to merge 9 commits into
Open
Conversation
superchilled
requested review from
dragonmantank
and
a lite review from Copilot
August 24, 2026 15:52
There was a problem hiding this comment.
Pull request overview
This PR extends the Video package’s Audio Connector request models to support configuring Audio Transport (e.g., JSON + Base64) and adds test coverage for the new configuration payload.
Changes:
- Added
AudioTransportConfigurationmodel and new enums (AudioTransportEncoding,AudioTransportTransport) to represent audio transport settings. - Extended
AudioConnectorWebSocketto accept anaudio_transportconfiguration and updated exports inmodels/__init__.py. - Updated unit tests to cover serialization of Audio Transport configuration.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
video/tests/test_audio_connector.py |
Adds/updates tests for serializing Audio Connector options, including the new audio_transport config. |
video/src/vonage_video/models/enums.py |
Introduces enums for audio transport encoding and transport type. |
video/src/vonage_video/models/audio_connector.py |
Adds AudioTransportConfiguration and wires it into AudioConnectorWebSocket. |
video/src/vonage_video/models/__init__.py |
Exposes the new model and enums at the package level. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
superchilled
marked this pull request as draft
August 24, 2026 16:01
superchilled
marked this pull request as ready for review
August 25, 2026 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Audio Connector implementation in the Video package to add configuration options for Audio Transport. Specifically it:
AudioTransportConfigurationdata model for setting the Audio Transport configuration optionsAudioConnectorWebSocketdata model to include theaudio_transportparameterAudioTransportEncodingandAudioTransportTransport__init.py