You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add the QUERY method as methodQuery and append QUERY to StdMethod.
Add hAcceptQuery for the Accept-Query response field name.
Re-export the new constants, add RFC-linked Haddocks, and extend method/header regression coverage.
This only adds the Accept-Query header name. It does not introduce Structured Fields parsing or a field-specific value model.
Compatibility
QUERY is appended after PATCH, preserving every existing derived Enum value. Adding a constructor to exported StdMethod can still break exhaustive downstream pattern matches, so the Haddocks and changelog target 0.13.
http-types.cabal remains at the currently unreleased 0.12.6; the package-version change is left to release preparation.
The reason will be displayed to describe this comment to others. Learn more.
I will merge this when I have time to publish.
I'd like to add this to the major bump I'm probably gonna do with #32, but I'll want to first "publish" it as a candidate and see what the general public feels about the additions.
I will merge this when I have time to publish. I'd like to add this to the major bump I'm probably gonna do with #32, but I'll want to first "publish" it as a candidate and see what the general public feels about the additions.
Is it OK if I include the header in the next minor release, and then keep the breaking Query addition to the StdMethod type for a later release, so that I can minimize the amount of major version bumps?
Is it OK if I include the header in the next minor release, and then keep the breaking Query addition to the StdMethod type for a later release, so that I can minimize the amount of major version bumps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to haskell-servant/servant#1900
Summary
QUERYmethod asmethodQueryand appendQUERYtoStdMethod.hAcceptQueryfor theAccept-Queryresponse field name.This only adds the
Accept-Queryheader name. It does not introduce Structured Fields parsing or a field-specific value model.Compatibility
QUERYis appended afterPATCH, preserving every existing derivedEnumvalue. Adding a constructor to exportedStdMethodcan still break exhaustive downstream pattern matches, so the Haddocks and changelog target0.13.http-types.cabalremains at the currently unreleased0.12.6; the package-version change is left to release preparation.