chore: derive CliRunner kwargs from the Click signature - #76
Merged
Conversation
- tests/conftest.py: pass mix_stderr only when the installed Click's CliRunner.__init__ still accepts it, checked via inspect.signature. This removes the type suppression and the try/except probe. - .pre-commit-config.yaml: the header now names the local gate job in .github/workflows/ci.yml as the CI consumer of this hook set; the _python-ci.yml reusable workflow is no longer referenced. Assisted-by: Claude:claude-fable-5 Claude-Session: https://claude.ai/code/session_01XKKV4NY5UNfrgXxXv83jvT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/conftest.py:cli_runner()passesmix_stderr=Falseonly when the installed Click'sCliRunner.__init__accepts the parameter, decided withinspect.signature. This removes the# type: ignore[call-arg]and the runtimetry/except TypeErrorprobe..pre-commit-config.yaml: the header comment names the localgatejob in.github/workflows/ci.ymlas the CI consumer of this hook set. The previous text named the_python-ci.ymlreusable workflow, which this repository no longer calls.Verification
ruff check .andruff format --check .— cleanpyright— 0 errors, 0 warningspytest— 1012 passed, 245 skippedpre-commit run --all-files— all hooks pass🤖 Generated with Claude Code
https://claude.ai/code/session_01XKKV4NY5UNfrgXxXv83jvT