Conversation
Reduce complex-cell reconstruction costs while preserving fallback behavior for special cells. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Keep optimized updates aligned with custom rendering and text layout semantics. Make the performance benchmark measurements reliable. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Avoid forwarding Promise objects through asynchronous fast updates. Verify button state changes during reuse. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Fall back from complex cell reuse when rapid hierarchy changes invalidate a cell definition. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Prevent stale graphics during complex cell reuse. Wait for scene updates before reporting performance samples. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Measure complex-cell scrolling against a same-run text control. Gate regressions in CI without relying on external baselines. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+28
to
+59
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Use Node.js 18 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18.x | ||
| cache: 'npm' | ||
| cache-dependency-path: './common/config/rush/pnpm-lock.yaml' | ||
|
|
||
| - name: Install dependencies | ||
| run: node common/scripts/install-run-rush.js install --bypass-policy | ||
|
|
||
| - name: Install Chromium | ||
| working-directory: packages/vtable | ||
| run: node node_modules/playwright/cli.js install --with-deps chromium | ||
|
|
||
| - name: Run scroll performance benchmark | ||
| working-directory: packages/vtable | ||
| env: | ||
| BENCHMARK_OUTPUT: benchmark-result.json | ||
| run: node ../../common/scripts/install-run-rushx.js benchmark:scroll | ||
|
|
||
| - name: Upload benchmark result | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: scroll-performance-result | ||
| path: packages/vtable/benchmark-result.json | ||
| if-no-files-found: ignore |
Keep idle completion time as diagnostic output because it varies by runner scheduling. Gate only metrics that distinguish the optimized and disabled fast paths. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Show gated metrics, limits, diagnostics, and run settings directly on the Actions summary page. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
rushx compileinpackages/vtableCloses #5308
🤖 Generated with Claude Code