Infer base repository from parent branch in retarget/restack#1749
Open
PawelLipski wants to merge 1 commit into
Open
Infer base repository from parent branch in retarget/restack#1749PawelLipski wants to merge 1 commit into
PawelLipski wants to merge 1 commit into
Conversation
In a fork workflow the PR/MR is hosted by the base (upstream) repository, not the head (fork) repository that holds the branches.
retarget-pr/restack-pr (and their GitLab retarget-mr/restack-mr counterparts) now resolve the code hosting client against the base repository
inferred from the parent branch's tracking remote - exactly like create-pr already does - so they query the repository that actually hosts the PR
even when no machete.{github,gitlab}.base* config keys are set.
Resolution is best-effort: if the base repository cannot be determined unambiguously and no base* keys are set, it falls back to the head repository,
preserving the previous behavior.
PawelLipski
added
github
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a fork workflow the PR/MR is hosted by the base (upstream) repository, not the head (fork) repository that holds the branches.
retarget-pr/restack-pr (and their GitLab retarget-mr/restack-mr counterparts) now resolve the code hosting client against the base repository
inferred from the parent branch's tracking remote - exactly like create-pr already does - so they query the repository that actually hosts the PR
even when no machete.{github,gitlab}.base* config keys are set.
Resolution is best-effort: if the base repository cannot be determined unambiguously and no base* keys are set, it falls back to the head repository,
preserving the previous behavior.