Add alt text to img elements for accessibility - #194
Open
ultraboy5522 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Thank you for opening a pull request @ultraboy5522. We will review it as soon as possible 🙌❤️
Author
|
Hi @Virtual4087, hope you're doing well! Whenever you get a chance, would you mind taking a quick look at this accessibility fix? No rush at all. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #190
audited and updated the
altattributes across all<img>tags on the page to make sure they follow proper accessibility (a11y/WCAG) standards:alt=""on the images. Because the image and the text label (e.g.,<span>Hong Kong</span>) live inside the same<a>tag, giving the image its ownalttext caused screen readers to read the country name twice ("Hong Kong image Hong Kong link"). Marking the image as decorative lets the screen reader just announce just the link text.alt="Target logo"andalt="Upward trend icon").Everything has been tested and works as intended.