Remove $PROGRAM_NAME version-print line (audition round 3)#2673
Open
joelhawksley wants to merge 2 commits into
Open
Remove $PROGRAM_NAME version-print line (audition round 3)#2673joelhawksley wants to merge 2 commits into
joelhawksley wants to merge 2 commits into
Conversation
Removes the trailing 'puts ViewComponent::VERSION::STRING if __FILE__ == $PROGRAM_NAME' from version.rb, which read a global variable (unshareable from non-main Ractors). The version remains available via ViewComponent::VERSION::STRING; nothing runs version.rb as a script. Also pins rubydex's precompiled platform variants in Gemfile.lock so 'bundle install' works without Cargo on platforms audition supports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 3 of audition Ractor-readiness work. Small by design: fixes the one remaining finding resolvable without breaking public APIs or the test suite; leaves the rest.
Changes:
Left for later (would risk API/tests/load-order): @@default_output_preamble/postamble (frozen-constant fix drops test_render_inline_allocations below its per-version floor); class_attribute/mattr_accessor (public config API); define_method blocks; class-level memoization (allocation-sensitive); autoload/lazy requires (deliberate load-order/optional-dep).
Verified: full suite green on Ruby 4.0 (517 runs, 0 failures); audition --static-only passes.