replaced custom CRD patches with property annotations - #2489
Conversation
There was a problem hiding this comment.
1 issue found across 32 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="api/operator/v1beta1/vlogs_types.go">
<violation number="1" location="api/operator/v1beta1/vlogs_types.go:84">
P2: These markers do not add a property-level schema for VLogs because the enclosing `VLogsSpec` is already schemaless, leaving the VLogs CRD behavior unchanged. If this is intended to replace the VLogs CRD patch, the parent must become structural or the custom patch must remain; otherwise these annotations are ineffective metadata.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
ce0fa35 to
5f34876
Compare
5f34876 to
46c7a50
Compare
|
I wonder if we can break up config/crd/patches/operator.victoriametrics.com_vlclusters.yaml into smaller patches: |
it's achieveable only with custom scripts as patches for CRs may have different property prefixes |
|
Ah, okay, sure - it seems feasible for some cases at least. I'll experiment with that and create a PR |
use annotations to consistently trim same fields in all CRDs, for the rest use custom patches