Skip to content

fix AbstractProtocol byte stream interference#481

Open
Cirsius wants to merge 1 commit intoViaVersion:ver/1.14-1.21from
Cirsius:ver/1.14-1.21
Open

fix AbstractProtocol byte stream interference#481
Cirsius wants to merge 1 commit intoViaVersion:ver/1.14-1.21from
Cirsius:ver/1.14-1.21

Conversation

@Cirsius
Copy link
Copy Markdown

@Cirsius Cirsius commented Apr 12, 2026

fixes bug with AbstractProtocol inheriting registerConfigurationChangeHandlers() which messed with the byte stream. this might also fix this issue

Copy link
Copy Markdown
Member

@florianreuth florianreuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very wrong, they need to be registered in order to have the correct states set for the handlers above. What error does this fix?

@octylphenol
Copy link
Copy Markdown

This seems very wrong, they need to be registered in order to have the correct states set for the handlers above. What error does this fix?

I have absolutely no idea how this works but it does seem to fix #468

@Cirsius
Copy link
Copy Markdown
Author

Cirsius commented Apr 12, 2026

This seems very wrong, they need to be registered in order to have the correct states set for the handlers above. What error does this fix?

"Cirsius lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.io.IOException: Packet play/serverbound/minecraft:configuration_acknowledged (class_8591) was larger than I expected, found 9 bytes extra whilst reading packet serverbound/minecraft:configuration_acknowledged" was the error i was getting and this stopped it from happening. ill look into seeing if theres a more proper fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants