Fix/legacy drop slot desync#1297
Open
Term4 wants to merge 2 commits into
Open
Conversation
1.17.1+ servers skip the hotbar slot resync after a drop action, assuming the client predicted it (ServerPlayer#drop marks the remote slot as already known) - clients below 1.17.1 don't predict drops, so the dropped stack ghosts in their hotbar. Convert drop item/stack actions into the equivalent throw-click on the selected hotbar slot at the 1.17.1 boundary: the click path does get resynced, and every affected client passes through this hop.
Empirical bisect (stock plugins, 26.2 vanilla): the drop ghost affects clients up to 1.13, not 1.17 - client-side drop prediction was added in 1.13.1, so every affected client passes through this hop instead. Gate on a 1.17.1+ server (older servers resync drops themselves); the upper hops convert the legacy click onward, including the 1.17.1 state id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern clients predict dropping items from hotbar locally, legacy ones do not.