Fall back sponge sounds to grass for 1.20.1 and below#135
Open
Term4 wants to merge 1 commit into
Open
Conversation
block.sponge.* and block.wet_sponge.* were added in 1.20.2; mapping them to empty silences sponge interactions entirely for older clients. Both blocks used SoundType.GRASS before 1.20.2, so the grass sounds are what older clients played natively. block.sponge.absorb keeps the drop - its legacy feedback came through levelEvent 2001 rather than a sound event. NOTE that 1.20.1 and below actually DO play a stone.break sound at pitch = 0.8, but that is dictated by the server NOT mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
block.sponge.* and block.wet_sponge.* were added in 1.20.2; mapping them to empty silences sponge interactions entirely for older clients. Both blocks used SoundType.GRASS before 1.20.2, so the grass sounds are what older clients played natively. block.sponge.absorb keeps the drop - its legacy feedback came through levelEvent 2001 rather than a sound event. NOTE that 1.20.1 and below actually DO play a stone.break sound at pitch = 0.8, but that is dictated by the server NOT mappings.