update refs - #11
Merged
Merged
Conversation
SimonCropp
marked this pull request as draft
August 17, 2026 01:43
SimonCropp
marked this pull request as ready for review
August 17, 2026 01:54
patriksvensson
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEEDS A SQUASH ON MERGE
Update refs: xunit.v3 4.0
Bumps xunit.v3 from 3.2.2 to 4.0.0, plus the fallout from that major bump.
Package updates
xunit.v3Roslynator.Analyzersglobal.json)Removed packages
xunit.runner.visualstudio— a VSTest adapter. xunit.v3 4.x runs natively onMicrosoft.Testing.Platform (MTP), so the adapter is dead weight.
Microsoft.NET.Test.Sdk— VSTest infrastructure, likewise unused under MTP.Removing
Microsoft.NET.Test.Sdkmeant losing theOutputType=Exeit was settingimplicitly, and xunit.v3 requires test projects to be executable. Both test projects
now set
<OutputType>Exe</OutputType>explicitly.Opt in to MTP mode of
dotnet testxunit.v3 4.0 pulls in Microsoft.Testing.Platform 2.x, which dropped the VSTest bridge
on the .NET 10 SDK. Without the opt-in,
dotnet testfails with:The opt-in goes in
global.json:Note this is the .NET 10 mechanism — the older
TestingPlatformDotnetTestSupportMSBuild property no longer works, since MTP 2 removed that path on .NET 10.
build.csneeded no change: MTP mode still accepts the solution positionally, so theexisting
DotNetTest("./src/Verify.Terminal.slnx", …)call works as-is.Obsolete parallelization API
CollectionBehaviorAttribute.DisableTestParallelizationis obsolete in 4.0, and thebuild treats all warnings as errors, so this was a hard build failure. Replaced with
the new attribute in
GlobalUsings.cs:Behaviour is unchanged — the integration tests still run serially, which they need to
because Verify keeps global static naming state and these tests hit the real filesystem.
Verification
Full
dotnet build.cs(Build → Test → Pack) is green: 54/54 tests passing acrossnet8.0 and net10.0, package produced, zero warnings.