Fix diff lines that were never rendered - #10
Merged
Conversation
Fixes #7 Four defects caused changes to be silently omitted from the review output: - Empty lines rendered as nothing. The word wrap calculation produced a piece count of zero for empty text, so the render loop never ran and an added or removed blank line was invisible. - The last line of a snapshot could never render, because the range Stop is exclusive but was clamped to New.Count - 1. - Changes running to the end of a snapshot were dropped entirely. Ranges were only flushed upon encountering a following unchanged line, so a change with no trailing unchanged line was never emitted. - Line numbers drifted after the first insertion or deletion, since both columns used the index into the aligned diff rather than the position of each side within its own snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Four defects caused changes to be silently omitted from the review output: