Switch container registry to Google Artifact Registry and honour uv.l…#256
Open
mgsalem wants to merge 2 commits into
Open
Switch container registry to Google Artifact Registry and honour uv.l…#256mgsalem wants to merge 2 commits into
mgsalem wants to merge 2 commits into
Conversation
…ock at build time - docker.yml: auth via WIF, push to GAR. Registry coordinates come from GCP_AR_REGION/GCP_PROJECT_ID/GCP_AR_REPOSITORY variables and GCP_WIF_PROVIDER/GCP_WIF_SERVICE_ACCOUNT secrets. - vllm.Dockerfile, sglang.Dockerfile: install pinned to uv.lock via 'uv export --frozen | uv pip install --no-deps' (uv pip install alone ignores the lockfile). Adds a build-time import canary. - README and docs/index: point to GAR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Other (CI / build pipeline)
Short Description
Switches container image publishing from Docker Hub to Google Artifact Registry, authenticated via Workload Identity Federation.
Registry coordinates are parameterized through GitHub Actions variables.
Also fixes the issue where
vllm.Dockerfile/sglang.Dockerfileignoreduv.lock(becauseuv pip installdoesn't read lockfiles — onlyuv syncdoes). The new install step exportsuv.lockto a pinnedrequirements.txtand installs with--no-deps, so the image matches the lockfile.Tests Added
No unit tests — change is CI/build-pipeline only. Verified by: