defaultarch: handle caller-set return addresses when inlining calls#8246
Open
appleflyerv3 wants to merge 1 commit into
Open
defaultarch: handle caller-set return addresses when inlining calls#8246appleflyerv3 wants to merge 1 commit into
appleflyerv3 wants to merge 1 commit into
Conversation
detect registers that are set to the caller's next addr before a call is inlined, and therefore treat the jumps to those regs in the callee IL as returns to the call label.
Author
|
This fix allows Binary Ninja to recognize during function inlining when an inlined function returns by jumping to a register that was set to the caller’s fallthrough address. (lifted via LLIL_JUMP) For example, this is used by RISC-V LLVM outlined functions such as Example: sub_function:
jal t0, OUTLINED_FUNCTION_1
...
jal t0, OUTLINED_FUNCTION_2
OUTLINED_FUNCTION_1:
addi sp, sp, -0x10
sw ra, 0xc(sp)
sw s0, 0x8(sp)
sw s1, 0x4(sp)
sw s2, 0x0(sp)
jr t0
OUTLINED_FUNCTION_2:
lw ra, 0xc(sp)
lw s0, 0x8(sp)
lw s1, 0x4(sp)
lw s2, 0x0(sp)
addi sp, sp, 0x10
jr t0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detect registers that are set to the caller's next addr before a call is inlined, and therefore treat the jumps to those regs in the callee IL as returns to the call label.