Implement DAA (and associated BCD flags)#8
Closed
samrussell wants to merge 7 commits into
Closed
Conversation
bugfix: add perform_get_address_size(self) to ColecoView feature: lifted RST, conditional CALL, CPL, NEG, RES, SET
Contributor
Author
|
Looks like the HLIL optimises out the constant n flag too, here's a BCD subtraction (above is addition):
|
Contributor
Author
Contributor
Author
|
Closed in favour of #10 |
mblsha
added a commit
to mblsha/Z80
that referenced
this pull request
Aug 26, 2025
- Add header comment explaining this is temporary until PR Vector35#8 is merged - Link to upstream PR: mblsha/binja-test-mocks#8 - Add TODO in pyproject.toml to update binja-test-mocks version - Once upstream fix is released, sitecustomize.py can be deleted The proper fixes have been contributed upstream to binja-test-mocks and will eliminate the need for runtime patching. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was fun, I'm not super concerned about flag output (except Z and C), it looks kinda nice in IL:
Looks a bit wild with the full flag calculation in the HLIL though:
Note that I've manually implemented the half-carry and it seems to resolve to the same as the default for carry implementation in the HLIL