fix bug in expressionify#2
Closed
samrussell wants to merge 1 commit into
Closed
Conversation
remove extra if at start that returns ints as-is, which means constants get interpreted as indices and it gives hilarious effects (e.g. flag calculating A with PUSH(BC) which then evaluates the push and throws the stack off)
Member
|
@samrussell would you like to convert this to a PR so I can merge it? Or you plan to add more commits on top of it later? |
Contributor
Author
|
Replaced by #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove extra if at start that returns ints as-is, which means constants get interpreted as indices and it gives hilarious effects (e.g. flag calculating A with PUSH(BC) which then evaluates the push and throws the stack off)