Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pageindex/index/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -741,13 +741,15 @@ def sanitize_filename(filename, replacement='-'):

def get_pdf_name(pdf_path):
# Extract PDF name
if isinstance(pdf_path, str):
if isinstance(pdf_path, (str, Path)):
pdf_name = os.path.basename(pdf_path)
elif isinstance(pdf_path, BytesIO):
pdf_reader = PyPDF2.PdfReader(pdf_path)
meta = pdf_reader.metadata
pdf_name = meta.title if meta and meta.title else 'Untitled'
pdf_name = sanitize_filename(pdf_name)
else:
pdf_name = 'Untitled'
return pdf_name


Expand Down
21 changes: 21 additions & 0 deletions tests/test_get_pdf_name.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from pathlib import Path

from pageindex.index.utils import get_pdf_name


def test_get_pdf_name_str():
assert get_pdf_name("/some/path/document.pdf") == "document.pdf"


def test_get_pdf_name_pathlib_path():
# Previously raised UnboundLocalError — Path is neither str nor BytesIO
assert get_pdf_name(Path("/some/path/document.pdf")) == "document.pdf"


def test_get_pdf_name_pathlib_relative():
assert get_pdf_name(Path("reports/annual.pdf")) == "annual.pdf"


def test_get_pdf_name_unknown_type_returns_untitled():
# Any unrecognised type should not crash — returns a safe fallback
assert get_pdf_name(12345) == "Untitled"