feat(variant-page): add synonymous nucleotide as a distinct measurement class#676
Open
bencap wants to merge 1 commit into
Open
feat(variant-page): add synonymous nucleotide as a distinct measurement class#676bencap wants to merge 1 commit into
bencap wants to merge 1 commit into
Conversation
…nt class Previously, associated nucleotide measurements were grouped with direct nucleotide measurements: they shared the same filter toggle, count, and card badge styling, making them visually and behaviorally indistinguishable. Changes: - Add dedicated `--color-synonymous-nucleotide` / `-light` / `-border` design tokens in app.css using a dark amber palette (#8a5700 / #fef8e1 / #f5c97a). - Rename the `associatedNucleotide` label from "Associated nucleotide" to "Synonymous nucleotide" / "Synonymous" (short) in measurement-types.ts and update its badge class to the new amber tokens. - In use-variant-lookup: split the shared nucleotide count/filter into separate `nucleotideCount` / `associatedNucleotideCount` computeds and a dedicated `showAssociatedNucleotide` ref; each of the three classes is now filtered independently in `filteredVariants`. - In VariantScreen.vue: add a third `MvBadgeToggle` for synonymous nucleotide (conditionally rendered when count > 0). The mobile dropdown derives its label from `MEASUREMENT_TYPE_LABELS[type].short` and automatically shows "Synonymous" with no further changes.
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, associated nucleotide measurements were grouped with direct nucleotide measurements: they shared the same filter toggle, count, and card badge styling, making them visually and behaviorally indistinguishable.
Changes:
--color-synonymous-nucleotide/-light/-borderdesign tokens in app.css using a dark amber palette (#8a5700 / #fef8e1 / #f5c97a).associatedNucleotidelabel from "Associated nucleotide" to "Synonymous nucleotide" / "Synonymous" (short) in measurement-types.ts and update its badge class to the new amber tokens.nucleotideCount/associatedNucleotideCountcomputeds and a dedicatedshowAssociatedNucleotideref; each of the three classes is now filtered independently infilteredVariants.MvBadgeTogglefor synonymous nucleotide (conditionally rendered when count > 0). The mobile dropdown derives its label fromMEASUREMENT_TYPE_LABELS[type].shortand automatically shows "Synonymous" with no further changes.