fix: require SDK release PR approval#1084
Merged
Merged
Conversation
Contributor
|
🌿 Preview your docs: https://vapi-preview-f7fc3bb6-d32e-46be-a5d6-8781ff16f987.docs.buildwithfern.com |
dhruva-vapi
force-pushed
the
dhruva/prism-1030-sdk-release-pr-approval
branch
from
c99d6ee to
dc33ab1
Compare
nikhil-gupta-vapi
approved these changes
Jun 25, 2026
Contributor
|
🌿 Preview your docs: https://vapi-preview-0c699afe-ad98-4005-bf8b-42bc9a90c57f.docs.buildwithfern.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Branch protection should make SDK release changes reviewable before they land. The current docs/Fern release path could still generate SDK commits/releases directly, which left package registries out of sync and gave Vapi no human approval point.
Test Plan
ruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "parsed #{f}" }' fern/apis/api/generators.yml .github/workflows/release-{ts,python,go,ruby,csharp,java,php,swift}-sdk.ymlfern checkLinear: PRISM-1030