wineopenxr: Remove wrapped XrSession from session list on destroy.#9915
Open
ImSapphire wants to merge 2 commits into
Open
wineopenxr: Remove wrapped XrSession from session list on destroy.#9915ImSapphire wants to merge 2 commits into
ImSapphire wants to merge 2 commits into
Conversation
This was causing a use-after-free in xrPollEvent if the runtime reuses a previous XrSession handle when the session is destroyed and recreated. Fixes Prism3D-based games (Euro Truck Simulator 2, American Truck Simulator) never calling xrBeginSession and running the frame loop if the host runtime reuses the XrSession handle when the engine destroys and recreates its session. Previously the game would ignore the XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED event since the evt->session pointer from the list was incorrect, we would retrieve the old session pointer. Signed-off-by: Sapphire <imsapphire0@gmail.com>
ImSapphire
force-pushed
the
sapphire/wineopenxr-session-uaf
branch
from
1c28f7d to
62e2231
Compare
Plagman
force-pushed
the
bleeding-edge
branch
5 times, most recently
from
6fdfce2 to
e3c25b2
Compare
|
same fix as this PR: #9485 |
Plagman
force-pushed
the
bleeding-edge
branch
17 times, most recently
from
cfbbd55 to
4b254b5
Compare
Plagman
force-pushed
the
bleeding-edge
branch
12 times, most recently
from
deab009 to
d183798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing a use-after-free in xrPollEvent if the runtime reuses a previous XrSession handle when the session is destroyed and recreated.
Fixes Prism3D-based games (Euro Truck Simulator 2, American Truck Simulator) never calling xrBeginSession and running the frame loop if the host runtime reuses the XrSession handle when the engine destroys and recreates its session. Previously the game would ignore the XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED event since the evt->session pointer from the list was incorrect, we would retrieve the old session pointer.