Let moderators edit another member's planet identity - #1660
Merged
Conversation
Adds a Manage Identity permission so mods can reset an inappropriate nickname or avatar instead of just reporting it (issue #1657). Same authority check as kick/ban, and logged to the moderation audit log. Also fixed nickname/avatar changes not showing up live in the member list or chat until you reopened them - same root cause hit the global username change too, fixed that alongside it.
SigmaTel71
reviewed
Aug 7, 2026
Comment on lines
+311
to
+312
| // You can always edit your own avatar, so we only check permissions | ||
| // if you are not the same as the target |
Member
There was a problem hiding this comment.
If I get it right, revoking identity editing permission from the user is not available yet and might be implemented in future.
Comment on lines
+631
to
+632
|
|
||
| public static readonly PlanetPermission ManageIdentity = new PlanetPermission(0x1000000, "Manage Identity", "Allow members to edit other members' planet nickname and avatar."); |
Member
There was a problem hiding this comment.
Hm... so the permissions are sorted by their mask rather than physical order? I'm looking at additions at lines 505 and 562 with neighboring lines.
…razor Co-authored-by: Vitaly Orekhov <vkvo2000@vivaldi.net>
Deploying valour-marketing with
|
| Latest commit: |
eecb4b0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79697754.valour-marketing.pages.dev |
| Branch Preview URL: | https://fix-mod-edit-identity.valour-marketing.pages.dev |
…razor Co-authored-by: Vitaly Orekhov <vkvo2000@vivaldi.net>
Co-authored-by: Vitaly Orekhov <vkvo2000@vivaldi.net>
Deploying valour with
|
| Latest commit: |
7f85e5f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17a34f57.valour.pages.dev |
| Branch Preview URL: | https://fix-mod-edit-identity.valour.pages.dev |
SigmaTel71
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1657 - moderators previously had no way to fix an inappropriate Planet Identity (per-planet nickname/avatar) other than telling the user to change it themselves.
EditIdentity.razorcomponent, reused by both the existing settings page and the new moderator modal, so there's one copy of the save logic instead of two.Note: this is my own interpretation of how to handle this - permission shape, authority-check reuse, and the shared-component split were all judgment calls on my end, so if there's a preferred approach or convention I should be following instead, happy to adjust.
Test plan