Move the SerializeReference window into Windows/ and split its views - #153
Draft
VPDPersonal wants to merge 4 commits into
Draft
Move the SerializeReference window into Windows/ and split its views#153VPDPersonal wants to merge 4 commits into
VPDPersonal wants to merge 4 commits into
Conversation
…d split its views
The window, its tabs and the code mutating managed references all lived under
SerializeReferences/Windows/, where two view files had grown past 1400 lines and
mixed UI with asset editing.
- Unity/Editor/Scripts/Windows/ now owns the window (TabWindow, TabWindowShortcuts,
TabType) and one folder per tab: References/{Asset,Project,Shared}, Settings/ and
Welcome/ (moved out of Scripts/Welcome/).
- The audit views are split into partials by responsibility — GraphView .Nodes /
.Cards / .Picker, ProjectView .Cards / .Actions — with counting and wording pulled
into pure *Analysis / *Summary types. The largest file is now ~430 lines, was 1600.
- SerializeReferences/Editing/ owns every mutation, free of UI and callable from
tests: SerializeReferenceGraphEditor, SerializeReferenceBatchEditor,
MissingReferenceGroup, SerializeReferenceOpenCopyGuard,
SerializeReferenceConstraintCache. Views ask it to edit and only decide whether to
repaint.
- HoverSweep folds into NavRing, and the canvas status colour moves from
SerializeReferenceCanvasStyle into AspidAnimatedDotsBackground's StatusStyle
(USS-driven), covered by AspidAnimatedDotsBackgroundStatusTests.
Every moved type stays internal and keeps its namespace — no public API change.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LiHHAeMSqFgwagXRNt5Q9R
- CLAUDE.md: the feature map now points at Unity/Editor/Scripts/Windows/, the References tab split (Asset / Project / Shared) and SerializeReferences/Editing/ as the layer owning every mutation; the file is translated to Russian - VisualElements/Internal/CLAUDE.md and the SerializeReference roadmap follow the moved paths Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LiHHAeMSqFgwagXRNt5Q9R
…w-tabs # Conflicts: # CLAUDE.md
The class it names was renamed in the move; the comment still said SerializeReferenceWindow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LiHHAeMSqFgwagXRNt5Q9R
VPDPersonal
added
type: refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializeReferences/Windows/into its ownUnity/Editor/Scripts/Windows/—TabWindow,TabWindowShortcuts,TabType, and one folder per tab:References/{Asset,Project,Shared},Settings/,Welcome/(the latter moved out ofScripts/Welcome/)GraphView.Nodes/.Cards/.Picker,ProjectView.Cards/.Actions— and pull counting and wording into pure*Analysis/*Summarytypes; largest file is now ~430 lines, down from 1600SerializeReferences/Editing/layer owning every mutation, free of UI and callable from tests:SerializeReferenceGraphEditor,SerializeReferenceBatchEditor,MissingReferenceGroup,SerializeReferenceOpenCopyGuard,SerializeReferenceConstraintCache— views ask it to edit and only decide whether to repaintHoverSweepintoNavRing, and move the canvas status colour fromSerializeReferenceCanvasStyleintoAspidAnimatedDotsBackground's USS-drivenStatusStyleAspidAnimatedDotsBackgroundStatusTestscovering the new status stylingCLAUDE.md(feature map, mutation layer, tab layout) and the SerializeReference roadmap to the new paths; the rootCLAUDE.mdis also translated to RussianNotes for review
SerializeReferenceWindow/HoverSweep/SerializeReferenceCanvasStyle, noUnityEditorusage underUnity/Runtime/). Worth a recompile + EditMode run before reviewinternaland keeps its namespace, and theTools/Aspid 🐍/FastTools/…menu paths are unchanged — no public API or UX change.metafiles travelled with their sources, so Unity keeps the existing GUIDsmainis merged in; its only conflict wasCLAUDE.md, where the branch's Russian text was kept andmain's analyzer submodule → subtree facts were ported into it🇷🇺 Описание на русском
Кратко
SerializeReferences/Windows/в собственную папкуUnity/Editor/Scripts/Windows/—TabWindow,TabWindowShortcuts,TabTypeи по папке на вкладку:References/{Asset,Project,Shared},Settings/,Welcome/(последняя переехала изScripts/Welcome/)GraphView.Nodes/.Cards/.Picker,ProjectView.Cards/.Actions, — а подсчёты и формулировки вынесены в чистые типы*Analysis/*Summary; самый большой файл теперь ~430 строк вместо 1600SerializeReferences/Editing/владеет каждой мутацией, свободен от UI и вызываем из тестов:SerializeReferenceGraphEditor,SerializeReferenceBatchEditor,MissingReferenceGroup,SerializeReferenceOpenCopyGuard,SerializeReferenceConstraintCache— представления просят его отредактировать и решают лишь, перерисовываться лиHoverSweepслит вNavRing, а цвет статуса холста переехал изSerializeReferenceCanvasStyleвStatusStyleкомпонентаAspidAnimatedDotsBackground(управляется через USS)AspidAnimatedDotsBackgroundStatusTestsна новую стилизацию статусаCLAUDE.md(карта функциональности, слой мутаций, раскладка вкладок) и roadmap по SerializeReference приведены к новым путям; корневойCLAUDE.mdзаодно переведён на русскийЗаметки для ревью
SerializeReferenceWindow/HoverSweep/SerializeReferenceCanvasStyle, нетUnityEditorвнутриUnity/Runtime/). Перед ревью стоит перекомпилировать и прогнать EditMode-тестыinternalи сохранили namespace, пункты менюTools/Aspid 🐍/FastTools/…не изменились — публичный API и UX не затронуты.metaпереехали вместе с исходниками, поэтому GUID'ы в Unity сохранилисьmainвлит; единственный конфликт был вCLAUDE.md— оставлен русский текст ветки, в него перенесены факты изmainпро перевод анализатора из сабмодуля в subtree