Merge upstream 5.0.6 - #3
Open
MajdSehwail wants to merge 154 commits into
Open
Conversation
…o embedded schemas
…d limit traverse error loop
hidden-input-for-type
Fix get type
Hidden input for type
relax phoenix_live_view version constraint
Make "mix test" completely quiet
…n-warning Remove warning when aliases cannot be expanded
Update Elixir requirement to 1.13+
types When using `use_parent_field_for_type` option in `polymorphic_embeds_one`, the `action_and_struct/4` function's cond block was missing a clause to handle the case when both `type_from_parent_field` and `type_from_map` are present and match. The existing cond only handled: 1. type_from_parent_field is nil -> :type_not_found 2. type_from_map is nil -> get module and return action/struct 3. types don't match -> raise error This caused a CondClauseError when form params included the `__type__` field matching the parent field type (e.g., during form validation). Added a `true` clause to handle the matching types case, which behaves the same as when type_from_map is nil - it uses the parent field type to determine the module and returns the appropriate action/struct tuple.
Fix CondClauseError when using use_parent_field_for_type with matching types
…deprecation Fix preferred cli env deprecation and update credo to support elixir v1.19
fix warning in Elixir 1.19
Fix nested embeds errors
- Resolve all conflicts in favor of upstream. - Upstream v4+ includes equivalent fixes for this fork's traverse_errors changes.
- traverse_errors/2 collects errors from any parameterized type that defines traverse_errors/4. - This is a fork-specific change with no upstream equivalent.
- cast_polymorphic_embed adds an "is invalid" changeset error for params with an invalid shape, instead of raising. - This is a fork-specific change with no upstream equivalent.
- Update phoenix, plug, and postgrex to versions without known advisories. - Ignore the decimal advisory CVE-2026-32686. The fix exists only in decimal 3.x, and ecto 3.12 requires decimal 2.x. The exposure is test-only for this library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our fork is based on v3.0.5 (2022). Upstream is now at v5.0.6. Upstream contains equivalent fixes for most of our patches, including the traverse_errors fixes for nested embeds and assocs. A small diff against upstream makes future upstream merges cheap.
mathieuprog/polymorphic_embedv5.0.6 (master) into our fork.traverse_errors/4hook. Other parameterized types can add their errors to traversal.