fix: path traversal, CORS, cache cap, __dirname, error pages, cookie order#1193
Open
yetval wants to merge 1 commit intoUseInterstellar:mainfrom
Open
fix: path traversal, CORS, cache cap, __dirname, error pages, cookie order#1193yetval wants to merge 1 commit intoUseInterstellar:mainfrom
yetval wants to merge 1 commit intoUseInterstellar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security fixes
Masqr.jsvia Host header — validate with allowlist regex, usepath.basename()instead of incompletenormalize().replace()Bug fixes
__dirnameusingprocess.cwd()instead ofimport.meta.url(ESM module — wrong dir when launched from different cwd)mime.getType()returningnullfor unknown extensions (now falls back toapplication/octet-stream)MasqFail()calls not being awaitedcookieParserregistered after route handlers — moved before routes so Masqr can read cookies on/e/*404.html— now serves500.htmlhttp.Serverhandler; Express middleware never ran on those routesReliability
CACHE_MAX_ENTRIES(default 1000, env-configurable) to prevent OOM under adversarial trafficheadersSentguard in asset proxy error handlerError pages
static/500.htmlFailed.htmlnginx placeholder with proper license-validation-failed pageCredentials
config.js— credentials now read fromBASIC_AUTH_USERSenv var (user:passCSV)Notes
MASQR=trueenv varCOOKIE_SECRETenv var required at startup whenMASQR=true