Skip to content

Added a test to check all robot model parametrizations#505

Merged
urfeex merged 8 commits into
UniversalRobots:masterfrom
urfeex:check_robot_model
May 19, 2026
Merged

Added a test to check all robot model parametrizations#505
urfeex merged 8 commits into
UniversalRobots:masterfrom
urfeex:check_robot_model

Conversation

@urfeex
Copy link
Copy Markdown
Member

@urfeex urfeex commented May 12, 2026

This PR adds a workflow to check the robot model as reported from the primary interface with the model argument provided to start_ursim.sh.

This also fixes passing ur7e or ur12e to PolyScope 5.

To reduce build resources, this PR splits the integration tests into a "build" stage and two "test" stages utilizing that build. This probably doesn't save any time, but build resources and makes handling a failed build easier.


Note

Medium Risk
Moderate risk because it restructures CI execution and modifies start_ursim.sh model normalization for UR7e/UR12e, which could break integration test orchestration or URSim startup if misconfigured.

Overview
Splits the integration workflow into a dedicated Ubuntu build job and downstream test jobs by archiving/uploading the CMake build directory and reusing it in run_tests (and a new check job), reducing repeated compilation.

Adds a new CI job to validate robot model parametrizations across many URSim versions/models by running only PrimaryClientTest.test_robot_type and reporting coverage with distinct Codecov flags.

Fixes UR7e/UR12e handling in scripts/start_ursim.sh so PolyScope 5 strips the trailing e while PolyScope X keeps UR7e/UR12e, with updated Bats assertions.

Introduces robotTypeFromString in helpers and a new GTest that compares the primary interface-reported robot type against the ROBOT_MODEL env var mapping (including UR7e→UR5 and UR12e→UR10).

Reviewed by Cursor Bugbot for commit 3cb96c9. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.80%. Comparing base (3f95311) to head (d77ceb8).

Files with missing lines Patch % Lines
src/helpers.cpp 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   76.96%   76.80%   -0.17%     
==========================================
  Files         116      116              
  Lines        6343     6354      +11     
  Branches     2761     2764       +3     
==========================================
- Hits         4882     4880       -2     
- Misses       1113     1125      +12     
- Partials      348      349       +1     
Flag Coverage Δ
check_version_ur10-3.15.8 11.08% <83.33%> (?)
check_version_ur10e-10.11.0 11.78% <83.33%> (?)
check_version_ur10e-5.15.2 11.73% <83.33%> (?)
check_version_ur12e-10.12.1 11.78% <83.33%> (?)
check_version_ur12e-5.25.1 11.73% <83.33%> (?)
check_version_ur15-10.12.1 11.73% <83.33%> (?)
check_version_ur15-5.25.1 11.73% <83.33%> (?)
check_version_ur16e-10.12.1 11.73% <83.33%> (?)
check_version_ur16e-5.25.1 11.73% <83.33%> (?)
check_version_ur18-10.12.1 11.73% <83.33%> (?)
check_version_ur18-5.25.1 11.73% <83.33%> (?)
check_version_ur20-10.12.1 11.73% <83.33%> (?)
check_version_ur20-5.25.1 11.73% <83.33%> (?)
check_version_ur3-3.14.3 12.45% <83.33%> (?)
check_version_ur30-10.12.1 11.73% <83.33%> (?)
check_version_ur30-5.25.1 11.73% <83.33%> (?)
check_version_ur3e-10.11.0 11.73% <83.33%> (?)
check_version_ur3e-5.9.4 11.73% <83.33%> (?)
check_version_ur5-3.15.8 12.17% <83.33%> (?)
check_version_ur5e-10.11.0 11.72% <83.33%> (?)
check_version_ur5e-5.12.8 11.73% <83.33%> (?)
check_version_ur7e-10.11.0 11.73% <83.33%> (?)
check_version_ur7e-5.22.2 11.93% <83.33%> (?)
check_version_ur8long-10.12.1 11.78% <83.33%> (?)
check_version_ur8long-5.25.1 11.73% <83.33%> (?)
python_scripts 75.90% <ø> (ø)
start_ursim 84.30% <100.00%> (-0.79%) ⬇️
ur20-latest 72.85% <0.00%> (-0.32%) ⬇️
ur5e-10.11.0 66.61% <0.00%> (-0.71%) ⬇️
ur5e-10.12.0 67.91% <0.00%> (-0.41%) ⬇️
ur5e-10.7.0 66.19% <0.00%> (-0.47%) ⬇️
ur5e-5.9.4 73.28% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/helpers.cpp
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 3cb96c9. Configure here.

Comment thread .github/workflows/ci.yml Outdated
@urfeex urfeex marked this pull request as draft May 18, 2026 06:26
@urfeex urfeex force-pushed the check_robot_model branch 2 times, most recently from 3cb96c9 to d77ceb8 Compare May 18, 2026 13:42
@urfeex urfeex marked this pull request as ready for review May 18, 2026 13:56
@urfeex urfeex merged commit de6faf8 into UniversalRobots:master May 19, 2026
54 of 62 checks passed
@urfeex urfeex deleted the check_robot_model branch May 19, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants