Added a test to check all robot model parametrizations#505
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 76.96% 76.80% -0.17%
==========================================
Files 116 116
Lines 6343 6354 +11
Branches 2761 2764 +3
==========================================
- Hits 4882 4880 -2
- Misses 1113 1125 +12
- Partials 348 349 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced May 13, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 3cb96c9. Configure here.
3cb96c9 to
d77ceb8
Compare
urrsk
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds a workflow to check the robot model as reported from the primary interface with the model argument provided to
start_ursim.sh.This also fixes passing ur7e or ur12e to PolyScope 5.
To reduce build resources, this PR splits the integration tests into a "build" stage and two "test" stages utilizing that build. This probably doesn't save any time, but build resources and makes handling a failed build easier.
Note
Medium Risk
Moderate risk because it restructures CI execution and modifies
start_ursim.shmodel normalization for UR7e/UR12e, which could break integration test orchestration or URSim startup if misconfigured.Overview
Splits the integration workflow into a dedicated Ubuntu build job and downstream test jobs by archiving/uploading the CMake
builddirectory and reusing it inrun_tests(and a new check job), reducing repeated compilation.Adds a new CI job to validate robot model parametrizations across many URSim versions/models by running only
PrimaryClientTest.test_robot_typeand reporting coverage with distinct Codecov flags.Fixes UR7e/UR12e handling in
scripts/start_ursim.shso PolyScope 5 strips the trailingewhile PolyScope X keepsUR7e/UR12e, with updated Bats assertions.Introduces
robotTypeFromStringinhelpersand a new GTest that compares the primary interface-reported robot type against theROBOT_MODELenv var mapping (including UR7e→UR5 and UR12e→UR10).Reviewed by Cursor Bugbot for commit 3cb96c9. Bugbot is set up for automated code reviews on this repo. Configure here.