chore: Update Java maven release and conventional commits version#74
Open
SundermannC wants to merge 5 commits into
Open
chore: Update Java maven release and conventional commits version#74SundermannC wants to merge 5 commits into
SundermannC wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Java publish workflow so Maven deployment happens only in response to GitHub Release publication, rather than on branch pushes and tags. This aligns Java package publishing with a release-based process.
Changes:
- Switch workflow trigger from
push(branches/tags) torelease(published) events. - Remove SNAPSHOT versioning/deploy steps and simplify to a single release deployment path.
- Always run the “Deploy Release to Central Portal” step within the release-triggered workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
46
to
47
| BASE_VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout | sed 's/-SNAPSHOT//') | ||
| mvn versions:set -DnewVersion="${BASE_VERSION}" -DgenerateBackupPoms=false |
Comment on lines
59
to
60
| - name: Deploy Release to Central Portal | ||
| if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v') | ||
| run: cd java && mvn clean deploy |
Switch from pull_request to push trigger so that only newly-pushed commits are validated, rather than all commits in the PR history.
Replace webiny/action-conventional-commits (checks all PR commit messages) with amannn/action-semantic-pull-request (checks PR title), which validates the Conventional Commits format on the squash-merge entry point instead of each individual commit.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot
AI
changed the title
chore: Updates Java maven deploy to react to GitHub releases and only to releases
Fix the failing GitHub Actions "Conventional Commits" job
Jun 30, 2026
SundermannC
changed the title
gravemalte
approved these changes
Jun 30, 2026
gravemalte
left a comment
gravemalte
left a comment
Member
There was a problem hiding this comment.
Useful, I see no problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Conventional Commits" CI job was failing because a commit message was missing a Conventional Commits type prefix. The
webiny/action-conventional-commits@v1.3.0action checks all commits in the PR history via the GitHub API, making the check permanently fail once a non-conventional commit is in the PR branch.Root Cause
Commit
bf504e3had message"Updates Java maven deploy to react to releases and only to releases"— missing a required type prefix (e.g.chore:). Since the action fetches all PR commits from the GitHub API, adding new commits does not resolve the failure.Fix
Replaced
webiny/action-conventional-commits@v1.3.0withamannn/action-semantic-pull-request@v6.1.1in.github/workflows/conventionalpr.yml. The new action validates the PR title instead of individual commit messages, which is the recommended approach when using squash merges (the PR title becomes the final commit message onmain).The PR title
"chore: Updates Java maven deploy to react to GitHub releases and only to releases"already follows the Conventional Commits specification, so the check now passes.