docs: fix discount fixture percentage keys - #90
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The custom fixture example documents amount-based keys for percentage discount tests:
DynamicFixtureContextdoes not read either key.business_logic_test.pyusesget_expected_discount_percentage()andget_expected_discount_percentage_2(), which look forexpected_discount_percentageandexpected_discount_percentage_2; following the README therefore falls back to0.0and makes the expected discount amount zero.The bundled flower-shop fixture already uses the percentage keys with values
10.0and20.0.Fix: align the README example and field descriptions with the percentage keys consumed by the test suite.
Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A
Checklist
!for breaking changes).generate_models.shunderpython_sdk. (Not applicable; no schema or model changes.)Screenshots / Logs (if applicable)