fix: disable response model for mock webhook route - #88
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MockWebhookServernow returns either aJSONResponsefor a simulated transient failure or a dictionary for success:FastAPI treats that union annotation as a response model and raises
FastAPIErrorwhile registering the route becauseJSONResponseis not a valid Pydantic response field. As a result, all nine webhook tests fail during setup before starting the mock server.Fix: set
response_model=Noneon the mock webhook route. This disables response-schema generation for the test endpoint while preserving its existing 500/200 status codes, bodies, and event recording.Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
500 {"status":"retry"}followed by200 {"status":"ok"}and records both statuses.webhook_structure_test.py: 6/6 passed.webhook_test.py: 3/3 passed.git diff --checkpassed.