fix: accept in-band missing fulfillment errors - #87
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
carolinerg1
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_complete_without_fulfillmentinvalidation_test.pyrequired thereference server's exact transport posture and message:
The checkout error model also permits business failures in-band on the existing
resource: a 2xx response with a typed
messages[]error while the checkoutremains non-completed. The same test file already handles both postures through
assert_business_error(...)for out-of-stock, unavailable-item, not-found, andpayment failures. The official playground uses code
missingfor a missingfulfillment destination.
Fix: use the existing dual-posture helper with
missingfor the in-bandcase and a case-insensitive
fulfillmentsubstring for a 4xx rejection.Category (Required)
Related Issues
N/A
Checklist
generate_models.shunderpython_sdk.Screenshots / Logs (if applicable)
validation_test.py: 6/6 passed against the reference Python server*_test.pyfiles passedpre-commit run --all-files: passed