Skip to content

Fix for UUM-143478#1116

Merged
sim-bz merged 4 commits into
mainfrom
uum-143478
Jun 1, 2026
Merged

Fix for UUM-143478#1116
sim-bz merged 4 commits into
mainfrom
uum-143478

Conversation

@sim-bz
Copy link
Copy Markdown
Collaborator

@sim-bz sim-bz commented May 28, 2026

[Delete any line or section that does not apply]

Purpose of this PR

Fix for UUM-143478
Added a null check to avoid an issue when deleting a CinemachineCamera with a CinemachinePixelPerfect extension.

Testing status

[Explanation of what’s tested, how tested and existing or new automation tests. Can include manual testing by self and/or QA. Specify test plans. Rarely acceptable to have no testing.]

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

[Overview of how documentation is affected by this change. If there is no effect on documentation, explain why. Otherwise, state which sections are changed and why.]

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

[Overall product level assessment of risk of change. Need technical risk & halo effect.]
Risk: Minimal
Halo: Minimal

Comments to reviewers

[Info per person for what to focus on, or historical info to understand who have previously reviewed and coverage. Help them get context.]

Package version

[Justification for updating either the patch, minor, or major version according to the semantic versioning rules]

  • Updated package version

Copy link
Copy Markdown
Contributor

@u-pr u-pr Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May require changes

An issue has been found regarding the use of C# pattern matching on a UnityEngine.Object derivative, which bypasses Unity's lifetime check and can cause exceptions.

🤖 Helpful? 👍/👎

Comment thread com.unity.cinemachine/Editor/Editors/CinemachinePixelPerfectEditor.cs Outdated
Comment thread com.unity.cinemachine/Editor/Editors/CinemachinePixelPerfectEditor.cs Outdated
Comment thread com.unity.cinemachine/Editor/Editors/CinemachinePixelPerfectEditor.cs Outdated
@codecov-github-com
Copy link
Copy Markdown

codecov-github-com Bot commented May 28, 2026

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ne/Editor/Editors/CinemachinePixelPerfectEditor.cs 0.00% 7 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   22.74%   22.74%   -0.01%     
==========================================
  Files         243      243              
  Lines       28682    28685       +3     
==========================================
  Hits         6523     6523              
- Misses      22159    22162       +3     
Flag Coverage Δ
cinemachine_MacOS_2022.3 ?
cinemachine_MacOS_2022.3_project ?
cinemachine_MacOS_6000.0 ?
cinemachine_MacOS_6000.0_project ?
cinemachine_MacOS_6000.3 ?
cinemachine_MacOS_6000.3_project ?
cinemachine_MacOS_6000.4 ?
cinemachine_MacOS_6000.4_project ?
cinemachine_MacOS_6000.5 ?
cinemachine_MacOS_6000.5_project ?
cinemachine_MacOS_6000.6 ?
cinemachine_MacOS_6000.6_project ?
cinemachine_Ubuntu_6000.0 ?
cinemachine_Ubuntu_6000.0_project ?
cinemachine_Ubuntu_6000.3 ?
cinemachine_Ubuntu_6000.3_project ?
cinemachine_Ubuntu_6000.4 ?
cinemachine_Ubuntu_6000.4_project ?
cinemachine_Ubuntu_6000.5 ?
cinemachine_Ubuntu_6000.5_project ?
cinemachine_Ubuntu_6000.6 ?
cinemachine_Ubuntu_6000.6_project ?
cinemachine_Windows_2022.3 17.09% <ø> (ø)
cinemachine_Windows_2022.3_project 22.74% <0.00%> (-0.01%) ⬇️
cinemachine_Windows_6000.0 17.06% <ø> (ø)
cinemachine_Windows_6000.0_project 22.70% <0.00%> (-0.01%) ⬇️
cinemachine_Windows_6000.3 17.06% <ø> (ø)
cinemachine_Windows_6000.3_project 22.70% <0.00%> (-0.01%) ⬇️
cinemachine_Windows_6000.4 17.06% <ø> (ø)
cinemachine_Windows_6000.4_project 22.70% <0.00%> (-0.01%) ⬇️
cinemachine_Windows_6000.5 17.06% <ø> (ø)
cinemachine_Windows_6000.5_project 22.70% <0.00%> (-0.01%) ⬇️
cinemachine_Windows_6000.6 17.06% <ø> (ø)
cinemachine_Windows_6000.6_project 22.70% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ne/Editor/Editors/CinemachinePixelPerfectEditor.cs 0.00% <0.00%> (ø)

ℹ️ Need help interpreting these results?

@sim-bz sim-bz requested a review from davidg-unity May 28, 2026 17:16
@sim-bz sim-bz merged commit b9b71a8 into main Jun 1, 2026
48 of 49 checks passed
@sim-bz sim-bz deleted the uum-143478 branch June 1, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants