Repository navigation
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change moves PR gating to the existing validation jobs and aligns the changelog header with the updated exemptions. I examined all changed files, dependency coverage, regeneration inputs, and changelog readers; no actionable issues were found.
Reviewed commit 9f0fb43
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2506 +/- ##
===========================================
+ Coverage 78.96% 79.21% +0.24%
===========================================
Files 767 769 +2
Lines 140949 141263 +314
===========================================
+ Hits 111305 111898 +593
+ Misses 29644 29365 -279
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeoUnity
approved these changes
Nov 11, 2026
LeoUnity
left a comment
LeoUnity
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! Left a small suggestion, but will defer to you on acting on it or not
Collaborator
|
Aware that running [Yamato] Publish Dry Run inputsystem](https://yamato.ds.unity3d.com/job/79666737?utm_source=github) would result in a failed job, yet wanted to test it out in this PR |
"Publish Dry Run inputsystem" has failed on every PR since mid-August with
PVP-40-1 on the "## [Unreleased] - yyyy-mm-dd" changelog header. The package
tooling team confirmed this is expected: a dry run has the same requirements
as a real publish, it doesn't read .yamato/wrench/pvp-exemptions.json, and a
package can't be published with an [Unreleased] section. develop is never
publishable, so the dry run can't be a PR gate.
- "All Functional Tests" now depends on the Validate jobs instead of the dry
run. They run upm-pvp require with our exemptions file, and were already
part of the gate through the dry run's dependencies.
- The changelog header is now "## [Unreleased]", which passes PVP-40-1.
- Replaced the PVP-40-1 exemption for the placeholder header with a PVP-41-1
exemption ("Changelog has no [Unreleased] section"), as the PVP-41-1 docs
recommend during development.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
K-Tone
force-pushed
the
anthony/pr-gate-on-validate
branch
from
November 11, 2026 13:40
9f0fb43 to
c522e60
Compare
Pauliusd01
approved these changes
Nov 11, 2026
Pauliusd01
left a comment
Pauliusd01
left a comment
Collaborator
There was a problem hiding this comment.
I don't know much about CI so my approval is of low merit but the logic seems sound and running that publish job is required before releasing anyway so it won't be ignored
josepmariapujol-unity
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since mid-August, "Publish Dry Run inputsystem" has failed on every PR to
develop:The package tooling team (PVP profile maintainers) confirmed this is expected:
upm-pvp publish --dry-runhas exactly the same requirements as a real publish. It tells you whether you could publish right now..yamato/wrench/pvp-exemptions.json. Only the centralpets.pvp-catalogprofiles apply, and their PVP-40-1 exemption for us is pinned to 1.9.0.[Unreleased]changelog section, and that exemption won't be extended.developis never in a publishable state, so the dry run can't be a PR gate. Following their recommendation, this PR:Tools/CI/Recipes/Triggers.cs, "All Functional Tests" now depends on the nineValidate - inputsystem - <editor> - <platform>jobs instead of the dry run. They runupm-pvp require "rme PVP-160-1 supported .yamato/wrench/pvp-exemptions.json", so our exemptions apply. They already ran as part of the PR gate through the dry run's dependencies, so the gate loses only the publish-only checks..yamato/triggers.ymlwas regenerated withTools/CI/regenerate.sh.## [Unreleased] - yyyy-mm-ddis now## [Unreleased]. Only the- yyyy-mm-ddplaceholder failed the regex."PVP-41-1": {"all": true}("Changelog has no [Unreleased] section"), which the PVP-41-1 docs recommend skipping in CI during development.Tools/CI/CI-CHANGES.md."Publish Dry Run inputsystem" is still generated and can be run manually, for example before a release or to test CI changes. It will keep failing while the changelog has an
[Unreleased]section, which is by design.Testing status & QA
.yamato/triggers.yml: the dry-run dependency is replaced by the nine Validate jobs, the same set the dry run depends on. No YAM002 "dependency references a job that does not exist" warnings.Overall Product Risks
Comments to reviewers
## [Unreleased]with## [x.y.z] - yyyy-mm-dd. The "Bump version" PR after a release must now add back## [Unreleased]without the- yyyy-mm-ddplaceholder, because PVP-40-1 is no longer exempted for it.ValidationJobsrecipe is internal, so the Validate job ids are built in the cookbook the same way Wrench names them. If Wrench changes the naming, regeneration logs a YAM002 warning.Checklist
Before review:
During merge:
CHANGE: ___.🤖 Generated with Claude Code