FIX: warnings / failures with CI#2425
Open
Darren-Kelly-Unity wants to merge 3 commits into
Open
Conversation
Darren-Kelly-Unity
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2425 +/- ##
===========================================
+ Coverage 78.13% 78.90% +0.77%
===========================================
Files 483 762 +279
Lines 98770 139248 +40478
===========================================
+ Hits 77169 109872 +32703
- Misses 21601 29376 +7775 Flags with carried forward coverage won't be shown. Click here to find out more.
|
Darren-Kelly-Unity
changed the title
Collaborator
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes CI build warnings by replacing
#if UNITY_EDITOR || DEVELOPMENT_BUILD/#if DEVELOPMENT_BUILDpreprocessor guards with#if DEBUGacross multiple runtime files. Also adds[NonSerialized]to fields inHID.HIDDeviceDescriptorDeviceEntryandHID.HIDElementDescriptorthat were triggering serialization warnings. One case inInputSystem.csuses a more precise fix: replaces#if DEVELOPMENT_BUILDwith a#if !UNITY_EDITORblock and a runtimeDebug.isDebugBuildcheck to preserve the original development-build-only remoting behaviour.Release Notes
None (internal CI / build-warning fixes only — no user-facing behaviour change).
Functional Testing status
No new tests added. Changes are limited to conditional-compilation guards and serialization attributes; existing automated test suite and CI pipeline cover the affected paths. Manual verification that remoting still activates correctly in development player builds is recommended.
Performance Testing Status
No performance impact. All changes are compile-time guards or serialization metadata attributes.
Overall Product Risks
Technical Risk: 1
Replacing
UNITY_EDITOR || DEVELOPMENT_BUILDwithDEBUGis semantically equivalent in the Unity editor and standard debug builds, but could differ in edge-case build configurations. TheInputSystem.csremoting path uses a runtimeDebug.isDebugBuildguard to avoid any behavioural regression.Halo Effect: 1
Changes are spread across 11 files in the runtime layer but are confined to debug/development-only code paths — no release-build behaviour is altered.
Class diagram
Types touched by
origin/develop...HEAD— no structural changes, all modifications are preprocessor guards or serialization attributes.classDiagram direction TB class InputControlExtensions { <<static>> } class ControlBuilder { <<struct>> +At() ControlBuilder +WithParent() ControlBuilder +WithName() ControlBuilder +WithLayout() ControlBuilder +WithUsages() ControlBuilder +WithChildren() ControlBuilder } class DeviceBuilder { <<struct>> +WithName() DeviceBuilder +WithLayout() DeviceBuilder +WithChildren() DeviceBuilder +WithControlUsage() DeviceBuilder +WithControlAlias() DeviceBuilder } class InputControlList { <<struct>> +Count int } class InputControlListDebugView { <<struct>> } class InputEventBuffer { <<struct>> } class InputManager { } class DeviceState { <<struct>> } class InputSystem { <<static>> } class RemoteInputPlayerConnection { } class InputRemoting { } class InputSystemState { } class EnhancedTouchSupport { <<static>> +CheckEnabled() } class HID { } class HIDDeviceDescriptorDeviceEntry { <<struct>> +deviceType Type +displayName string } class HIDElementDescriptor { <<struct>> +usageMin int +usageMax int +flags HIDElementFlags } class PlayerInputManager { } class InputStateBuffers { } InputControlExtensions --> ControlBuilder : creates InputControlExtensions --> DeviceBuilder : creates InputControlList --> InputControlListDebugView : debug view InputManager --> DeviceState : contains InputSystem --> RemoteInputPlayerConnection : owns InputSystem --> InputRemoting : uses HID --> HIDDeviceDescriptorDeviceEntry : contains HID --> HIDElementDescriptor : contains